MC-TVConverter is deleting the .edl files, but shouldn't

Discuss individual versions of MC-TVConverter (bugs,...)

MC-TVConverter is deleting the .edl files, but shouldn't

Postby JustinChase » 16. Apr 2012, 01:29

I was trying to amend my processing workflow to allow for a .ts file to be left alone (convert to .ts), and not moved, nor renamed. The desire is to have a show recorded to a subfolder, have MCTVC run comskip, and just delete the intermediate files (the .log and .txt), leaving only the original recording and the new commercial file next to it. This all works fine, except that when it deletes the intermediate files, it's also deleting the .edl file (as well as any other commercial files, like VPjr and xml) that the comskip.ini is set to keep. Here is a snip from the log file...

4/15/2012, 6:08:56 PM: -------- watching folder started
4/15/2012, 6:08:56 PM: callFunc: "watchFolder"
4/15/2012, 6:08:56 PM: watching folder started for directory: "V:\test\"
4/15/2012, 6:09:01 PM: currentFile: V:\test\Windsor Arrow Back Chairs - (09_19_2011)_09h59m.ts
4/15/2012, 6:09:01 PM: converting from ts to ts
4/15/2012, 6:09:01 PM: callFunc: "convert_ts2ts"
4/15/2012, 6:09:01 PM: callFunc: "checkStream"
4/15/2012, 6:09:01 PM: run (get streamInfo): "C:\Program Files (x86)\MC-TVConverter\tools\ffmpeg\ffmpeg.exe" -i "V:\test\Windsor Arrow Back Chairs - (09_19_2011)_09h59m.ts"
4/15/2012, 6:09:02 PM: streamInfo: stream has MPEG2 video
4/15/2012, 6:09:02 PM: streamInfo: stream has no AAC LATM audio
4/15/2012, 6:09:02 PM: streamInfo: stream has no E-AC3 audio
4/15/2012, 6:09:02 PM: streamInfo: stream has AC3 audio
4/15/2012, 6:09:02 PM: callFunc: "findCommercials"
4/15/2012, 6:09:02 PM: callFunc: "checkStream"
4/15/2012, 6:09:02 PM: run (get streamInfo): "C:\Program Files (x86)\MC-TVConverter\tools\ffmpeg\ffmpeg.exe" -i "V:\test\Windsor Arrow Back Chairs - (09_19_2011)_09h59m.ts"
4/15/2012, 6:09:02 PM: streamInfo: stream has MPEG2 video
4/15/2012, 6:09:02 PM: streamInfo: stream has no AAC LATM audio
4/15/2012, 6:09:02 PM: streamInfo: stream has no E-AC3 audio
4/15/2012, 6:09:02 PM: streamInfo: stream has AC3 audio
4/15/2012, 6:09:02 PM: run: "C:\Program Files (x86)\MC-TVConverter\tools\comskip\comskip.exe" "V:\test\Windsor Arrow Back Chairs - (09_19_2011)_09h59m.ts"
4/15/2012, 6:15:04 PM: No commercials found
4/15/2012, 6:15:04 PM: delete intermediate file: "V:\test\Windsor Arrow Back Chairs - (09_19_2011)_09h59m.edl"
4/15/2012, 6:15:04 PM: delete intermediate file: "V:\test\Windsor Arrow Back Chairs - (09_19_2011)_09h59m.VPrj"
4/15/2012, 6:15:04 PM: delete intermediate file: "V:\test\Windsor Arrow Back Chairs - (09_19_2011)_09h59m.xml"
4/15/2012, 6:15:04 PM: delete intermediate file: "V:\test\Windsor Arrow Back Chairs - (09_19_2011)_09h59m.log"
4/15/2012, 6:15:04 PM: delete intermediate file: "V:\test\Windsor Arrow Back Chairs - (09_19_2011)_09h59m.txt"

4/15/2012, 6:15:04 PM: rename file to: "V:\test\Windsor Arrow Back Chairs - (09_19_2011)_09h59m.ts"
4/15/2012, 6:15:04 PM: renameFile: target filename already exists - cannot rename file
4/15/2012, 6:15:04 PM: get orig file created date: 20120403040809
4/15/2012, 6:15:04 PM: set converted file created date to: 20120403040809 - "V:\test\Windsor Arrow Back Chairs - (09_19_2011)_09h59m.ts"

I suspect this has to do with the file name never changing, but I'm not sure. is this fixable, or does the file need to be moved and/or renamed for this to work?

Other than this, it's been working great since I tested the beta release!! :)
JustinChase
 
Posts: 42
Joined: 10.2011
Gender:

Re: MC-TVConverter is deleting the .edl files, but shouldn't

Postby hudl » 16. Apr 2012, 08:19

If you look at the line above your marked ones, it states that it didn't find any commecials. I delete all created files in this case because there is no need for them. Or do you want to keep the files also if there are no commercials in the video? Of course you could select to keep the intermediate files in settings but then all other conversions and helper files will be kept too...
Creator of MC-TVConverter
User avatar
hudl
Forum Admin
 
Posts: 119
Joined: 04.2011
Gender:

Re: MC-TVConverter is deleting the .edl files, but shouldn't

Postby JustinChase » 16. Apr 2012, 16:35

I wondered if that might be the reason. I'm trying to help someone else set up their system (in an online forum), and I think they reported that this was happening when there were commercials found, but I'll test myself when I get home, just to be sure.

I think it might be better to just keep the commercial files, even if blank, so a user knows the process completed properly, but I can understand just deleting them also.

I'll do more testing and report back if I still think something needs changed.

thanks again!
JustinChase
 
Posts: 42
Joined: 10.2011
Gender:

Re: MC-TVConverter is deleting the .edl files, but shouldn't

Postby JustinChase » 17. Apr 2012, 17:32

I was able to do some more testing, and can confirm that it is working correctly, as long as there are commercials in the file. I still think it might be better to create/keep the edl file even if blank, just so a user knows that it ran comskip, but it's not a big deal, so I'm not too worried about it, if you don't want to bother making the change :)

Unfortunately, that was only one of the issues the user has run into. He lives in a country that broadcasts TV with the AVC/h.264 video codec, which the "regular" version of Comskip cannot process. However, the Donator version of Comskip is able to process these files. I suggested they put the donator version in the tools\comskip folder that you use, but it still didn't work. I see from the log that you are checking for mpeg video, and apparently not running comskip if there is no mpeg video. This certainly makes sense, but is causing the videos to not be processed.

Is there any way you can allow the user to use the Donator version if they have it? Either by allowing a custom path to Comskip, or by you not making this check for mpeg video, and just letting Comskip fail if it's unable to process the file? Or maybe with some other solution I'm not thinking of?

Thanks again for all your prompt help with issues, I really appreciate it!
JustinChase
 
Posts: 42
Joined: 10.2011
Gender:

Re: MC-TVConverter is deleting the .edl files, but shouldn't

Postby nwboater » 17. Apr 2012, 17:53

Hi,

I'm the "User" that JustinChase was talking about in his last post. I would like to clarify the issue a bit.

I live in Canada, but I don't believe that the Cable broadcast we receive are AVC files. The issue arises because we use an Hauppauge HDPVR 'Tuner'. It is the one that puts out the files in AVC/h.264 for the video. I believe the Hauppauge Collosus would do the same. Both are popular tuners.

I have been using SageTV for several years and am now trying to switch to JRiver Media Center 17. Comskip has been working fine in SageTV but to use it with the HDPVR one has to have the Donators Version of comskip. It is installed in a separate Comskip folder in Program files. The Comskip 'Detector' plugin for Sage uses that version of Comskip.

So if there would be a way to use the Donators Version of Comskip with your program we could then be commerical free in JRiver MC. That would be wonderful!

And speaking of wonderful your program is. Thanks very much for creating it and sharing it.

Best Regards,
Rod
nwboater
 
Posts: 1
Joined: 04.2012
Gender:

Re: MC-TVConverter is deleting the .edl files, but shouldn't

Postby hudl » 18. Apr 2012, 12:48

Hi and welcome!
I'm glad the GUI is of help for you!

Unfortunately I currently don't have plans to include the possibility to use the donation version of comskip. It would mean to much changes in the code - indeed I would have to change all profiles which is the most time consuming part in development.
Anyhow, I collect all user requests and if I feel the app is stable enough and has all basic features working fine (currently I rework audio processing), I will concentrate on these additional features. So, don't expect it too soon, but not all hope ist lost... ;)

PS: the next version will also process h264 encoded streams with comskip but will convert it to mpeg2 first - so, it will work, but it will have disadvantages.
Creator of MC-TVConverter
User avatar
hudl
Forum Admin
 
Posts: 119
Joined: 04.2011
Gender:


Return to "MC-TVConverter (english discussion)"

 

Who is online

Users browsing this forum: No registered users and 1 guest

cron